dymensionxyz / dymension-rdk

Framework for building highly scalable RollApps
Apache License 2.0
96 stars 53 forks source link

no error event is emitted/logged in case of ibc err ack #532

Closed omritoptix closed 1 week ago

omritoptix commented 2 weeks ago

In case an error ack is returned, the error should be emitted as event for debug purposes. currently there is no error emitted which makes it hard to understand the root cause.

danwt commented 1 week ago

there is already an event right

https://github.com/cosmos/ibc-go/blob/893b7afd6e924a347866336918e37d880d67b0fc/modules/core/04-channel/keeper/events.go#L179-L205

danwt commented 1 week ago

https://github.com/cosmos/ibc-go/blob/6fbc8c926706969ee3dd47950014a0d65348fb3f/modules/core/04-channel/keeper/packet.go#L356

zale144 commented 1 week ago

@danwt yea, but where the err at

danwt commented 1 week ago

but it's written right here https://github.com/cosmos/ibc-go/blob/893b7afd6e924a347866336918e37d880d67b0fc/modules/core/04-channel/keeper/events.go#L193 in the bytes

zale144 commented 1 week ago

I know that, I'm talking about the actual ’err‘ that is the root cause, not the obfuscated generic message with abci code