search

dymensionxyz / dymension

Dymension Hub
https://dymension.xyz
Other
362 stars 338 forks source link

x/sequencers: dry unbonding code #1066

Closed danwt closed 3 weeks ago

danwt commented 1 month ago

There are too many callsites and ad hoc actions occuring across the unbonding code. Each semantic action needs to happen in once place and be triggered by hooks or clean calls.

There is also too much WET code.

https://github.com/dymensionxyz/dymension/blob/acd9d13935a98dd43d13affdd440a78c85f3a961/x/sequencer/keeper/unbond.go#L1-L183

danwt commented 1 month ago

@mtsitrin I believe you said you will handle some of this in your rotation PR