search

dymensionxyz / dymension

Dymension Hub
https://dymension.xyz
Other
364 stars 340 forks source link

proposer field is `false` though it's the only sequencer #1150

Open omritoptix opened 1 month ago

omritoptix commented 1 month ago

Screenshot 2024-08-26 at 17 38 05

zale144 commented 4 weeks ago

the Proposer field is now deprecated and is never set to true. The only reason it's not deleted is because it is referenced in the v4 upgrade handler. Can we still remove the field @mtsitrin ?

mtsitrin commented 4 weeks ago

@omritoptix this field is deprecated. it's not used anywhere but the migration handler to v4

zale144 commented 4 weeks ago

I suppose it's important how it's used:

if oldSequencer.Proposer {
    sequencerkeeper.SetProposer(ctx, oldSequencer.RollappId, oldSequencer.Address)
}

so, I think we're not in a hurry to remove it, we can leave it until running V4 upgrade on mainnet