search

dymensionxyz / dymension

Dymension Hub
https://dymension.xyz
Other
367 stars 340 forks source link

Slash should not burn non-dym #1262

Closed danwt closed 4 weeks ago

danwt commented 1 month ago

In x/sequencer/keeper/unbond.go:77, the Hub logic handles the bond of jailed sequencers by burning them. While this is working as designed if the bond is denominated only in DYM, this may not always be the case; for example, if the bond is partly made of IBC tokens, these tokens may require the burn to happen in their source chain. Recommendation We recommend changing the jailing logic to seize tokens in favor of a trusted treasury address instead of burning them.

omritoptix commented 1 month ago

min bond is a param. we can assume it's always DYM for the time being. so I'm not gonna close this issue but it's not for 3D.

mtsitrin commented 1 month ago

Sequencer bond is currently enforced to be single denom (DYM) (https://github.com/dymensionxyz/dymension/pull/1292)

danwt commented 4 weeks ago

Thanks @mtsitrin , closing