Closed zale144 closed 3 weeks ago
The updates add a FulfillmentState
enum for demand orders, allowing queries based on fulfillment status (FULFILLED
, UNFULFILLED
). Changes affect proto definitions, command-line interface, gRPC queries, and relevant test cases. This extension enhances the granularity of order status queries, streamlining filtering for demand order fulfillment states in the eIBC module.
File Path | Change Summary |
---|---|
proto/dymension/eibc/query.proto |
Added FulfillmentState enum and integrated fulfillment_state field in QueryDemandOrdersByStatusRequest . |
x/eibc/client/cli/query_command_orders.go |
Extended list-demand-orders CLI command to include fulfillment parameter for filtering. |
x/eibc/keeper/grpc_query.go |
Introduced isFulfillmentState function to filter demand orders based on fulfillment state. |
x/eibc/keeper/grpc_query_test.go |
Updated tests to include fulfillment state checks and added cases for FULFILLED and UNFULFILLED . |
x/eibc/keeper/keeper.go |
Modified control flow with an outer: label in ListDemandOrdersByStatus function. |
sequenceDiagram
participant User
participant CLI
participant Keeper
participant QueryServer
User->>CLI: Execute `list-demand-orders status [params]`
CLI->>QueryServer: ListDemandOrdersByStatusRequest
QueryServer->>Keeper: Validate request and filter by FulfillmentState
Keeper->>QueryServer: Return filtered DemandOrders
QueryServer->>CLI: Return response
CLI->>User: Display DemandOrders
Objective | Addressed | Explanation |
---|---|---|
eIBC should allow queries by fulfillment state (#831) |
✅ |
In fields of code where logic plays,
New states emerge in querying ways,
Fulfillment now can shine so bright,
In orders' statuses, clear as light.
Our CLI dances, filters in place,
While tests ensure there's no disgrace.
Here's to code that strides ahead,
With eIBC, well-fed! 🐇✨
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
I'm not sure I like that the args have to be ordered
Closes #831
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval:
Summary by CodeRabbit
New Features
FULFILLED
andUNFULFILLED
states to query demand orders.Enhancements
Tests