search

dymensionxyz / dymension

Dymension Hub
https://dymension.xyz
Other
363 stars 327 forks source link

Shared package tech debts #931

Open danwt opened 3 weeks ago

danwt commented 3 weeks ago

The genesis bridge, when it goes in, will create a couple of tech debts:

Probably the RDK or the Hub would be a good place to move these definitions, which would introduce a dependency from repo to the other, but this is favoured by some on the team (as opposed to an entirely new repo).

omritoptix commented 3 weeks ago

I think this could lead to circular dependencies which I'm definitely against.

e.g:

  1. we will require rollapp DRSs in the hub (for fraud proof) - best to avoid until we'll have more elegant solution but as a first step maybe.
  2. the rollapp will require the hub (for this package)

This could get messy fast imo.

danwt commented 2 weeks ago

Ok I dont' have a strong opinion I do feel we need somewhere for 'shared' stuff Michael was against adding more repos

I am happy to add third/fourth/nth.. shared repos This is actually the status-quo: ie.g rdk, hub, dymint and rollapp-evm all depend on testify/ It's just the normal way of doing development