feat(genesis bridge): genesis transfers

[danwt]

Description

See

https://github.com/dymensionxyz/research/issues/278 for the master issue.

Recommended to start reviewing with https://github.com/dymensionxyz/dymension/blob/danwt/932-genesis-bridge/x/rollapp/transfergenesis/doc.go and https://github.com/dymensionxyz/dymension-rdk/blob/danwt/448-genesis-bridge/x/hub-genesis/keeper/ibc_module.go#L39-L77

There are a few outstanding items, that this PR does not try to solve.

This PR:

• Adds a new ante handler to see if ibc transfers are allowed for the rollapp
• fixes naming for our 'middlewares' to make them clearly one of ibc module / ics4 wrapper / middleware
• adds a new temporary ibc module to set the canonical channel id, since we no longer do that using a whitelisted addr
• adds a new ibc module to handle incoming 'genesis transfers'. It validates the special memo and registers a denom. It will not allow any regular transfers if transfers are not enabled
• adds genesis transfers bookkeeping to the rollapp genesis state
• renames is_genesis_event on the rollapp gensis state to 'transfers_enabled' this is backwards compatible
• removes concept of passing genesis accounts and denoms in the create rollapp message
• moves our various utils to properly namespaced packages under utils/
• adds a gerr (google error ) and derr (dymension error) packages for idiomatic error handling. (In future we will consolidate across dymint/rdk)
• dry out existing middlewares to make use of new .GetValidTransfer* functions which take care of parsing and validating the fungible packet, and querying and validating any associated rollapp and finalizations
• removes the obsolete ValidateRollappId func and sub funcs
• adds the notion of skipctx to delayedack, to skip it with a special sdk context value
• adds a transfersenabled flag to createRollapp (might be changed in future)
• simplify GetAllBlockHeightToFinalizationQueue

---

Closes https://github.com/dymensionxyz/dymension/issues/932

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

• [ ] Added a relevant changelog entry to the Unreleased section in CHANGELOG.md
• [ ] Targeted PR against the correct branch
• [ ] included the correct type prefix in the PR title
• [ ] Linked to the GitHub issue with discussion and accepted design
• [ ] Targets only one GitHub issue
• [ ] Wrote unit and integration tests
• [ ] Wrote relevant migration scripts if necessary
• [ ] All CI checks have passed
• [ ] Added relevant godoc comments
• [ ] Updated the scripts for local run, e.g genesis_config_commands.sh if the PR changes parameters
• [ ] Add an issue in the e2e-tests repo if necessary

SDK Checklist

• [ ] Import/Export Genesis
• [ ] Registered Invariants
• [ ] Registered Events
• [ ] Updated openapi.yaml
• [ ] No usage of go map
• [ ] No usage of time.Now()
• [ ] Used fixed point arithmetic and not float arithmetic
• [ ] Avoid panicking in Begin/End block as much as possible
• [ ] No unexpected math Overflow
• [ ] Used sendCoin and not SendCoins
• [ ] Out-of-block compute is bounded
• [ ] No serialized ID at the end of store keys
• [ ] UInt to byte conversion should use BigEndian

Full security checklist here

----;

For Reviewer:

• [ ] Confirmed the correct type prefix in the PR title
• [ ] Reviewers assigned
• [ ] Confirmed all author checklist items have been addressed

---;

After reviewer approval:

• [ ] In case the PR targets the main branch, PR should not be squash merge in order to keep meaningful git history.
• [ ] In case the PR targets a release branch, PR must be rebased.

[coderabbitai[bot]]

[!IMPORTANT]

Review skipped

More than 25% of the files skipped due to max files limit. The review is being skipped to prevent a low-quality review.

55 files out of 117 files are above the max files limit of 50. Please upgrade to Pro plan to get higher limits.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

- [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)

Tips

### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 54.81283% with 507 lines in your changes missing coverage. Please review.

Project coverage is 28.64%. Comparing base (c3d9307) to head (961625f). Report is 5 commits behind head on main.

:exclamation: Current head 961625f differs from pull request most recent head 260d7a6

Please upload reports for the commit 260d7a6 to get more accurate results.

Files	Patch %	Lines
x/rollapp/types/genesis_transfer.pb.go	2.81%	276 Missing :warning:
x/rollapp/types/genesis.pb.go	7.54%	49 Missing :warning:
x/rollapp/transfergenesis/ibc_module.go	67.60%	36 Missing and 10 partials :warning:
x/rollapp/keeper/authenticate_packet.go	62.26%	15 Missing and 5 partials :warning:
x/delayedack/ibc_middleware.go	76.92%	10 Missing and 5 partials :warning:
x/delayedack/keeper/transfer.go	61.29%	8 Missing and 4 partials :warning:
x/transferinject/ics4_wrapper.go	71.79%	8 Missing and 3 partials :warning:
x/rollapp/transfersenabled/ante_decorator.go	70.96%	6 Missing and 3 partials :warning:
x/rollapp/keeper/genesis_transfer.go	88.05%	6 Missing and 2 partials :warning:
x/rollapp/types/tx.pb.go	63.15%	5 Missing and 2 partials :warning:
... and 17 more

Additional details and impacted files

```diff @@ Coverage Diff @@ ## main #933 +/- ## ========================================== - Coverage 29.15% 28.64% -0.52% ========================================== Files 243 255 +12 Lines 34148 33646 -502 ========================================== - Hits 9957 9638 -319 + Misses 22710 22665 -45 + Partials 1481 1343 -138 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

[danwt]

Thanks @zale144 for the review Just two questions remaining

1. https://github.com/dymensionxyz/dymension/pull/933#discussion_r1642631997
2. What is the imports problem? I don't see a problem. I ran goimports and it's fine?

[danwt]

@mtsitrin thanks for the review I've addressed your comments and requested another Thanks

[danwt]

@mtsitrin I made an issue to replace the ante handler with an ics4 module https://github.com/dymensionxyz/dymension/issues/957