Closed zale144 closed 3 months ago
The recent changes introduce a new FulfillerAddress
field to the DemandOrder
structure, enabling better tracking of order fulfillment events. This enhancement aims to provide additional information for indexing and querying, specifically for the eibc-client’s funds tracking.
File | Change Summary |
---|---|
CHANGELOG.md |
Documented the addition of FulfillerAddress to DemandOrder . |
proto/.../demand_order.proto |
Added fulfiller_address field to the DemandOrder message. |
x/eibc/keeper/keeper.go |
Updated FulfillOrder function to set FulfillerAddress of DemandOrder . |
x/eibc/types/demand_order.go |
Included FulfillerAddress attribute in the events returned by the GetEvents method. |
x/eibc/types/types.go |
Added AttributeKeyFulfillerAddress constant for event attributes. |
sequenceDiagram
participant User
participant SDK_Context as sdk.Context
participant Keeper
participant DemandOrder
User->>Keeper: FulfillOrder(ctx, order, fulfillerAddress)
Keeper->>DemandOrder: Set FulfillerAddress(fulfillerAddress.String())
DemandOrder->>Keeper: Return updated order
Keeper->>SDK_Context: Emit updated events with FulfillerAddress
Objective | Addressed | Explanation |
---|---|---|
Add extra information to eibc order events (#873) | ✅ | |
Provide fulfiller address in DemandOrder events (#873) | ✅ |
🌟 A rabbit’s tale to share today,
The fulfiller’s role in a grand display.
Orders filled with an address so neat,
Tracks all steps, a mighty feat.
With every byte and protocol align,
DemandOrder’s path is so divine. 🌸
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
Description
Closes #873
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval:
Summary by CodeRabbit
FulfillerAddress
toDemandOrder
.FulfillOrder
function now sets theFulfillerAddress
field.DemandOrder
now include theFulfillerAddress
attribute if present.