dymensionxyz / dymension

Dymension Hub
https://dymension.xyz
Other
364 stars 341 forks source link

feat(denommetadata): register IBC denom on transfer #956

Closed zale144 closed 3 months ago

zale144 commented 3 months ago

Description


Closes #955

All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.

PR review checkboxes:

I have...

SDK Checklist

Full security checklist here

----;

For Reviewer:

---;

After reviewer approval:

mtsitrin commented 3 months ago

UT fails

zale144 commented 3 months ago

Please, instead of reintroducing all the old stuff, just move the ibc module and ics4 wrapper from transferinject and put your changes in there

If you look at main, currently, all the middlewares are very consistent in their pattern and use the authenticate packet utils

https://github.com/dymensionxyz/dymension/blob/4565f34fe8a8d2cd9e34a42bd6e3cf71ecbfecd9/x/rollapp/keeper/authenticate_packet.go#L21

It's all been dried out

Also please for errors, now prefer to use our gerr cosmos package and wrap them instead of defining new errors a lot. (You can still define new errors, but it's rare to need to do so)

https://pkg.go.dev/github.com/dymensionxyz/gerr-cosmos@v0.1.2/gerrc#pkg-variables

what do you mean reintroducing all the old stuff? transferinject has been removed with this PR, it's all moved to denommetadata