Open zale144 opened 5 days ago
Closes what issue?
Biggest open question I have is, there are several calls to ListRollappPackets in our code and after this PR not all of them are batched with a limit
So why can't memory problems occur at one of those places?
The scope of this PR is to address the potential DoS when deleting the finalized and reverted packets
The task is really to fix the DOS, the one in after epoch is just an example. If you think it should be broken down into multiple PRs then create issues to fix the other places. I don't see why adding a limit to after epoch solves the problem when the grpc queries and FinalizeRollappPackets still do everything unlimited?
Also, some of the naming is still sloppy IMO and the keepers/ module is unwarranted
The task is really to fix the DOS, the one in after epoch is just an example. If you think it should be broken down into multiple PRs then create issues to fix the other places. I don't see why adding a limit to after epoch solves the problem when the grpc queries and FinalizeRollappPackets still do everything unlimited?
Also, some of the naming is still sloppy IMO and the keepers/ module is unwarranted
The FinalizeRollappPackets issue is tracked separately and will be addressed in another PR. For this one, it's just preventing out of bonds memory use.
Description
Closes #320
All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow-up issues.
PR review checkboxes:
I have...
Unreleased
section inCHANGELOG.md
godoc
commentsSDK Checklist
map
time.Now()
sendCoin
and notSendCoins
Full security checklist here
----;
For Reviewer:
---;
After reviewer approval: