search

dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
98 stars 70 forks source link

sequencer rotation p2p sync validation - ADR #1115

Open omritoptix opened 1 month ago

omritoptix commented 1 month ago

Quoting @srene:

I'd like to: 1 - see what are all the rotation cases and make sure that nothing breaks regarding signature validation when rotation. 2 - see what are the implications of all cases to syncing from p2p and understand if in some cases p2p will need to be paused, for instance. 3 - list what is missing in terms of implementation.

srene commented 1 month ago

related to #1112

srene commented 1 month ago

also check e2e test with edge cases for sequencer rotation

omritoptix commented 1 month ago

@srene as far as I understand there is no issue there?

srene commented 1 month ago

if im not wrong, p2p gossip packets will be rejected in case of nodes are still syncing (because rotation packet is not applied yet and signature validation will fail). imo what it still needs to be done is : 1- do some research whether rejecting gossiped packets can be avoided when rotation for nodes syncing. 2- check if packet rejection has any impact on gossipsub protocol