dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
97 stars 67 forks source link

feat!: block batch submission determined by max bytes #794

Closed mtsitrin closed 4 months ago

mtsitrin commented 4 months ago

Following changes:

This PR also handles #807 it removes produce signals from the submitter and manages all production related in the producer only can be reviewed on this commit https://github.com/dymensionxyz/dymint/pull/794/commits/9364c7cf0bd124b6db1e0d64ea57e115557409ec

PR Standards

Opening a pull request should be able to meet the following requirements


Closes https://github.com/dymensionxyz/dymint/issues/728

<-- Briefly describe the content of this pull request -->

For Author:


For Reviewer:


After reviewer approval:

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 80.76923% with 10 lines in your changes are missing coverage. Please review.

Project coverage is 40.42%. Comparing base (851b312) to head (0d4c641). Report is 9 commits behind head on main.

:exclamation: Current head 0d4c641 differs from pull request most recent head c0af697. Consider uploading reports for the commit c0af697 to get more accurate results

Files Patch % Lines
block/submit.go 71.42% 5 Missing and 1 partial :warning:
block/produce.go 87.50% 2 Missing :warning:
config/config.go 0.00% 1 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #794 +/- ## ========================================== - Coverage 40.44% 40.42% -0.03% ========================================== Files 120 119 -1 Lines 18935 18861 -74 ========================================== - Hits 7659 7625 -34 + Misses 10201 10168 -33 + Partials 1075 1068 -7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.