dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
97 stars 67 forks source link

`namespaceID` as a block field is probably redundent #806

Closed mtsitrin closed 2 months ago

mtsitrin commented 4 months ago

Currently, besides the DA's namespace param, which used for blob submission, we also have Namespace field in the block itself.

Seems redundant and unused

mtsitrin commented 4 months ago

@srene do u think it can be removed or we missing something?

srene commented 4 months ago

it do not see any reason why we need a namespace_id param in the block manager. for da submission it is used the namespace id param from da_config only.

srene commented 4 months ago

The namespaceid config parameter is as field used in the block manager, that is actually included in every block header. I would not remove it by now, since modifying header fields can be a critical update

mtsitrin commented 4 months ago

well we can leave it in the header type, just not fill it if it's unused