Closed srene closed 1 month ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 39.83%. Comparing base (
851b312
) to head (a4c4ae8
). Report is 15 commits behind head on main.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
not sure if I understood what is the point of this pr? There was too much demand for the mutex before?
it avoids receiving extra duplicates from gossipsub protocol by passing extra options in p2p/client.go, this reduces the demand of the mutex. also it avoids adding already received blocks to the cache, in case it happens.
@mtsitrin can we merge?
PR Standards
This PR is aimed at preventing the reception of duplicated blocks from p2p network, by updating Gossipsub router configuration. It also prevents adding blocks to cache when already received. This improves performance and syncing times, because receiving too many packets from p2p may block applying blocks received from DA.
Opening a pull request should be able to meet the following requirements
Close #795 #803 <-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval: