dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
90 stars 61 forks source link

feat(p2p): remove availability checks from retriever #835

Closed srene closed 1 month ago

srene commented 1 month ago

PR Standards

This PR removes the availability checks from the retriever, since it requires additional syncing with DA and availability checks are not really necessary at this point where sequencers are trusted and fraud proofs are not enabled yet in full-nodes.

Opening a pull request should be able to meet the following requirements


Close #834

<-- Briefly describe the content of this pull request -->

For Author:


For Reviewer:


After reviewer approval:

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 40.40%. Comparing base (851b312) to head (aab2158). Report is 8 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #835 +/- ## ========================================== - Coverage 40.44% 40.40% -0.05% ========================================== Files 120 119 -1 Lines 18935 18868 -67 ========================================== - Hits 7659 7623 -36 + Misses 10201 10170 -31 Partials 1075 1075 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mtsitrin commented 1 month ago

I'm fine to merge it, but to notice, it affects not only full nodes but also a sequencer that needs to be synced initially (in syncBlockManager function)