dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
97 stars 67 forks source link

fix(da): full-nodes can sync from p2p while DA light client is down or out of sync #857

Closed srene closed 4 months ago

srene commented 4 months ago

PR Standards

The main objective of this PR is the startup process for Celestia DA for full-nodes. With the modifications, full nodes will not wait for a DA to be in sync (or up) and it will do the syncing process in the background, while the full-node can start receiving and caching gossiped blocks from P2P. It also solves a nil pointer error that was happening when DA light finished syncing and a full-node was started when was not still in sync. Without the modifications of this PR, a node could start receiving gossiped blocks, but everything received while DA was syncing was disregarded because the block manager was not started, waiting for the celestia light node to finish the syncing process.

Opening a pull request should be able to meet the following requirements


Close #856 , #799 , https://github.com/dymensionxyz/dymint/issues/770

<-- Briefly describe the content of this pull request -->

For Author:


For Reviewer:


After reviewer approval:

danwt commented 4 months ago

conflicts @srene

danwt commented 4 months ago

btw, solves https://github.com/dymensionxyz/dymint/issues/770?

srene commented 4 months ago

btw, solves #770?

yes, the problem was coming from da stuck in the starting process when celestia was syncing meanwhile the node was starting to get batches. I opened a new issue for that, so i think we can close 770

danwt commented 4 months ago

Please do gofumpt -w . to format