dymensionxyz / dymint

Sequencing Engine for Dymension RollApps

Other

90 stars 61 forks source link

chore(config): better naming for settlement config #868

Closed mtsitrin closed 1 month ago

mtsitrin commented 1 month ago

PR Standards

Opening a pull request should be able to meet the following requirements

Close #493

<-- Briefly describe the content of this pull request -->

For Author:

[ ] Targeted PR against correct branch
[ ] included the correct type prefix in the PR title
[ ] Linked to Github issue with discussion and accepted design
[ ] Targets only one github issue
[ ] Wrote unit and integration tests
[ ] All CI checks have passed
[ ] Added relevant godoc comments

For Reviewer:

[ ] confirmed the correct type prefix in the PR title
[ ] Reviewers assigned
[ ] confirmed all author checklist items have been addressed

After reviewer approval:

[ ] In case targets main branch, PR should be squashed and merged.
[ ] In case PR targets a release branch, PR should be rebased.

mtsitrin commented 1 month ago

shouldn't we also add the settlement prefix to the retry params to be consistent?

I thought about changing only the "confusing" fields

danwt commented 1 month ago

just an idea maybe we can use a toml lib to write this in future instead of a template https://pkg.go.dev/github.com/BurntSushi/toml#section-readme might be hard to add comments though