dymensionxyz / dymint

Sequencing Engine for Dymension RollApps
Other
90 stars 61 forks source link

fix(settlement): hub disconnect and reconnect causes sequencer to send wrong batch #889

Closed mtsitrin closed 3 weeks ago

mtsitrin commented 1 month ago
  1. doesn't break the accpetance loop on rpc errors
  2. handle the case where batch was accepted but we timed-out waiting for it

PR Standards

Opening a pull request should be able to meet the following requirements

--

PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A


Close #884

<-- Briefly describe the content of this pull request -->

For Author:


For Reviewer:


After reviewer approval:

danwt commented 3 weeks ago

there is some panic in the test https://github.com/dymensionxyz/dymint/actions/runs/9351213453/job/25736400514?pr=889

I wonder if our existing code is already flaky in this regard

mtsitrin commented 3 weeks ago

there is some panic in the test https://github.com/dymensionxyz/dymint/actions/runs/9351213453/job/25736400514?pr=889

I wonder if our existing code is already flaky in this regard

Its some racing in the graceful shutdown flow