Closed zale144 closed 2 weeks ago
The recent changes streamline the build process by consolidating version information handling in the Makefile
and enhance the rpc_test.go
file by updating endpoint values and adding expected JSON messages for health scenarios. These modifications ensure the node version is correctly queried and returned, improving overall functionality and testing accuracy.
File | Change Summary |
---|---|
Makefile | Removed COMMIT_HASH assignment, consolidated LD_FLAGS assignment, and updated BUILD_FLAGS . |
rpc/rpc_test.go | Updated endpoint values from "/status" to "/health" , added expectedMessage field, and imported io . |
The changes are straightforward and primarily involve updates to build configurations and test cases. A sequence diagram is not necessary for these changes.
Objective (Issue #) | Addressed | Explanation |
---|---|---|
Ensure querying for status returns the actual node version (#882) | ✅ | |
Add Prometheus metric for node version (#882) | ❌ | The changes do not include the addition of a Prometheus metric. |
In the land of code, where versions sing,
A rabbit hops with joyful spring.
Makefile cleaned, tests refined,
Health checks now with ease aligned.
Node version clear, a task well done,
Under the coding sun, we’ve won! 🌟
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
This doesn't fix the issue in deployed nodes, see this comment: https://github.com/dymensionxyz/dymint/issues/882#issuecomment-2161000070
In the Makefile, the version is not properly passed. Also,
TestNodeHealthRPCPropagation
test doesn't really test anything, so now it will test the result of/health
endpoint when publishing a data health status event with existing errorPR Standards
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #882
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval:
Summary by CodeRabbit
Bug Fixes
Tests