Closed srene closed 2 weeks ago
The changes introduce a new constant Grpc
to the list of data availability clients in the da/da.go
file. Additionally, the GetClientType
method in DataAvailabilityLayerClient
now returns da.Grpc
, and the SubmitMetaData
field's Client
value has been updated to da.Grpc
. These changes ensure that the correct data availability type for gRPC is used, addressing the issue of wrong DA type usage.
File(s) | Change Summary |
---|---|
da/da.go |
Added a new constant Grpc of type Client to the list of data availability clients. |
da/grpc/grpc.go |
Updated GetClientType method to return da.Grpc and changed SubmitMetaData field's Client value to da.Grpc . |
The changes are straightforward and do not significantly alter the control flow or introduce new features that require a sequence diagram.
Objective (Issue #) | Addressed | Explanation |
---|---|---|
Fix wrong DA type for gRPC (Issue #910) | ✅ |
In the code, a change so sleek, A gRPC update we did seek. Constants aligned, the type now true, Data flows as it should do. With
Grpc
in place, errors subside, A smoother journey, a flawless ride. Hooray for code, let’s celebrate, For bugs we've squashed, the fix is great!
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
PR Standards
It is not possible to use grpc DA because it fails in DA path da type checks. This PR fixes it by adding the DA type for grpc and using it correctly.
Opening a pull request should be able to meet the following requirements
--
PR naming convention: https://hackmd.io/@nZpxHZ0CT7O5ngTp0TP9mg/HJP_jrm7A
Close #910
<-- Briefly describe the content of this pull request -->
For Author:
godoc
commentsFor Reviewer:
After reviewer approval:
Summary by CodeRabbit
New Features
Grpc
.Updates
GetClientType
method now returnsGrpc
instead ofCelestia
.SubmitMetaData
field's client value has been updated fromMock
toGrpc
.