search

dymensionxyz / e2e-tests

Dymension e2e tests
25 stars 11 forks source link

Feat: Test sequencer slashed jailed #205

Closed hoangdv2429 closed 3 months ago

hoangdv2429 commented 3 months ago

Close https://github.com/dymensionxyz/e2e-tests/issues/161 Must merge this in order to work https://github.com/decentrio/rollup-e2e-testing/pull/52

NOTE: Current setup only have one sequencer address, add check for inability to register new sequencer later

Summary by CodeRabbit

hoangdv2429 commented 3 months ago

Tests failed because we don't have QuerySequencerStatus yet.

hoangdv2429 commented 3 months ago

@anhductn2001 https://github.com/decentrio/rollup-e2e-testing/pull/54 can you merge this, I need it in branch v6 instead of main

coderabbitai[bot] commented 3 months ago

[!WARNING]

Review failed

The pull request is closed.

Walkthrough

The changes introduce new end-to-end test targets in the Makefile and modify multiple test files to account for a 0.1% bridge fee deduction in balance assertions. Additionally, a new test function TestRollAppSqcSlashedJailed_EVM is added to ensure a sequencer is slashed and jailed upon a freeze government proposal passing. These updates enhance the testing framework to cover new scenarios and ensure accuracy in balance calculations.

Changes

Files/Groupings Change Summary
Makefile Added new end-to-end test targets for freezing scenarios with sequencer slashed and jailed for EVM and Wasm.
tests/frozen_test.go Introduced TestRollAppSqcSlashedJailed_EVM to test sequencer slashing and jailing upon freeze proposal.
tests/setup.go Updated rollappEVMImage version to "latest".
tests/eibc_corrupted_memo_test.go Adjusted balance assertion to subtract 0.1% bridge fee in TestEIBCCorruptedMemoNegative_EVM.
tests/eibc_fulfillment_test.go Adjusted balance calculations to account for 0.1% bridge fee in multiple test functions.
tests/eibc_invariant_test.go Adjusted balance calculations to account for 0.1% bridge fee in both EVM and Wasm tests.
tests/eibc_nobalance_test.go Introduced 0.1% bridge fee deduction in balance verification in TestEIBCNoBalanceToFulfillOrder_EVM.
tests/eibc_not_fulfillment_test.go Adjusted balance comparison logic to subtract 0.1% bridge fee in both EVM and Wasm tests.
tests/ibc_grace_period_test.go Updated balance assertions to account for 0.1% bridge fee in various test functions.
tests/ibc_pfm_with_grace_period_test.go Added import for cosmossdk.io/math and updated assertions for balance checks to account for bridge fee.
tests/ibc_transfer_test.go Adjusted balance assertion to subtract 0.1% bridge fee in TestIBCTransferSuccess_EVM.
tests/rollapp_genesis_event_test.go Added import for cosmossdk.io/math and adjusted balance assertions for bridge fee calculations.
tests/rollapp_upgrade_test.go Added import for cosmossdk.io/math and adjusted balance assertion for bridge fee in TestRollappUpgradeNonStateBreaking_EVM.

Sequence Diagram(s) (Beta)

sequenceDiagram
    participant User
    participant RollApp
    participant GovProposal
    participant Sequencer
    participant BalanceChecker

    User->>RollApp: Initiate freeze proposal
    RollApp->>GovProposal: Submit proposal
    GovProposal->>RollApp: Proposal passes
    RollApp->>Sequencer: Slash and jail sequencer
    User->>BalanceChecker: Check balance
    BalanceChecker-->>User: Balance minus 0.1% bridge fee

Assessment against linked issues

Objective (Issue #161) Addressed Explanation
Test for rollapp freeze with sequencer slashed and jailed ✅
Balance adjustments for bridge fee in various tests ✅

Poem

In the land of code so bright, Balance checks now feel just right. With bridge fees counted, none shall fail, Sequencers slashed, sent to jail. Tests so thorough, changes grand, Our RollApp stands, strong and planned.

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share - [X](https://twitter.com/intent/tweet?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A&url=https%3A//coderabbit.ai) - [Mastodon](https://mastodon.social/share?text=I%20just%20used%20%40coderabbitai%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20the%20proprietary%20code.%20Check%20it%20out%3A%20https%3A%2F%2Fcoderabbit.ai) - [Reddit](https://www.reddit.com/submit?title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&text=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code.%20Check%20it%20out%3A%20https%3A//coderabbit.ai) - [LinkedIn](https://www.linkedin.com/sharing/share-offsite/?url=https%3A%2F%2Fcoderabbit.ai&mini=true&title=Great%20tool%20for%20code%20review%20-%20CodeRabbit&summary=I%20just%20used%20CodeRabbit%20for%20my%20code%20review%2C%20and%20it%27s%20fantastic%21%20It%27s%20free%20for%20OSS%20and%20offers%20a%20free%20trial%20for%20proprietary%20code)
Tips ### Chat There are 3 ways to chat with [CodeRabbit](https://coderabbit.ai): - Review comments: Directly reply to a review comment made by CodeRabbit. Example: - `I pushed a fix in commit .` - `Generate unit testing code for this file.` - `Open a follow-up GitHub issue for this discussion.` - Files and specific lines of code (under the "Files changed" tab): Tag `@coderabbitai` in a new review comment at the desired location with your query. Examples: - `@coderabbitai generate unit testing code for this file.` - `@coderabbitai modularize this function.` - PR comments: Tag `@coderabbitai` in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples: - `@coderabbitai generate interesting stats about this repository and render them as a table.` - `@coderabbitai show all the console.log statements in this repository.` - `@coderabbitai read src/utils.ts and generate unit testing code.` - `@coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.` - `@coderabbitai help me debug CodeRabbit configuration file.` Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. ### CodeRabbit Commands (invoked as PR comments) - `@coderabbitai pause` to pause the reviews on a PR. - `@coderabbitai resume` to resume the paused reviews. - `@coderabbitai review` to trigger an incremental review. This is useful when automatic reviews are disabled for the repository. - `@coderabbitai full review` to do a full review from scratch and review all the files again. - `@coderabbitai summary` to regenerate the summary of the PR. - `@coderabbitai resolve` resolve all the CodeRabbit review comments. - `@coderabbitai configuration` to show the current CodeRabbit configuration for the repository. - `@coderabbitai help` to get help. Additionally, you can add `@coderabbitai ignore` anywhere in the PR description to prevent this PR from being reviewed. ### CodeRabbit Configration File (`.coderabbit.yaml`) - You can programmatically configure CodeRabbit by adding a `.coderabbit.yaml` file to the root of your repository. - Please see the [configuration documentation](https://docs.coderabbit.ai/guides/configure-coderabbit) for more information. - If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: `# yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json` ### Documentation and Community - Visit our [Documentation](https://coderabbit.ai/docs) for detailed information on how to use CodeRabbit. - Join our [Discord Community](https://discord.com/invite/GsXnASn26c) to get help, request features, and share feedback. - Follow us on [X/Twitter](https://twitter.com/coderabbitai) for updates and announcements.
hoangdv2429 commented 3 months ago

should pass now

hoangdv2429 commented 3 months ago

TODO: Change the rest to match coding style