Closed hoangdv2429 closed 3 months ago
Tests failed because we don't have QuerySequencerStatus
yet.
@anhductn2001 https://github.com/decentrio/rollup-e2e-testing/pull/54 can you merge this, I need it in branch v6 instead of main
[!WARNING]
Review failed
The pull request is closed.
The changes introduce new end-to-end test targets in the Makefile and modify multiple test files to account for a 0.1% bridge fee deduction in balance assertions. Additionally, a new test function TestRollAppSqcSlashedJailed_EVM
is added to ensure a sequencer is slashed and jailed upon a freeze government proposal passing. These updates enhance the testing framework to cover new scenarios and ensure accuracy in balance calculations.
Files/Groupings | Change Summary |
---|---|
Makefile | Added new end-to-end test targets for freezing scenarios with sequencer slashed and jailed for EVM and Wasm. |
tests/frozen_test.go | Introduced TestRollAppSqcSlashedJailed_EVM to test sequencer slashing and jailing upon freeze proposal. |
tests/setup.go | Updated rollappEVMImage version to "latest" . |
tests/eibc_corrupted_memo_test.go | Adjusted balance assertion to subtract 0.1% bridge fee in TestEIBCCorruptedMemoNegative_EVM . |
tests/eibc_fulfillment_test.go | Adjusted balance calculations to account for 0.1% bridge fee in multiple test functions. |
tests/eibc_invariant_test.go | Adjusted balance calculations to account for 0.1% bridge fee in both EVM and Wasm tests. |
tests/eibc_nobalance_test.go | Introduced 0.1% bridge fee deduction in balance verification in TestEIBCNoBalanceToFulfillOrder_EVM . |
tests/eibc_not_fulfillment_test.go | Adjusted balance comparison logic to subtract 0.1% bridge fee in both EVM and Wasm tests. |
tests/ibc_grace_period_test.go | Updated balance assertions to account for 0.1% bridge fee in various test functions. |
tests/ibc_pfm_with_grace_period_test.go | Added import for cosmossdk.io/math and updated assertions for balance checks to account for bridge fee. |
tests/ibc_transfer_test.go | Adjusted balance assertion to subtract 0.1% bridge fee in TestIBCTransferSuccess_EVM . |
tests/rollapp_genesis_event_test.go | Added import for cosmossdk.io/math and adjusted balance assertions for bridge fee calculations. |
tests/rollapp_upgrade_test.go | Added import for cosmossdk.io/math and adjusted balance assertion for bridge fee in TestRollappUpgradeNonStateBreaking_EVM . |
sequenceDiagram
participant User
participant RollApp
participant GovProposal
participant Sequencer
participant BalanceChecker
User->>RollApp: Initiate freeze proposal
RollApp->>GovProposal: Submit proposal
GovProposal->>RollApp: Proposal passes
RollApp->>Sequencer: Slash and jail sequencer
User->>BalanceChecker: Check balance
BalanceChecker-->>User: Balance minus 0.1% bridge fee
Objective (Issue #161) | Addressed | Explanation |
---|---|---|
Test for rollapp freeze with sequencer slashed and jailed | ✅ | |
Balance adjustments for bridge fee in various tests | ✅ |
In the land of code so bright, Balance checks now feel just right. With bridge fees counted, none shall fail, Sequencers slashed, sent to jail. Tests so thorough, changes grand, Our RollApp stands, strong and planned.
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?
should pass now
TODO: Change the rest to match coding style
Close https://github.com/dymensionxyz/e2e-tests/issues/161 Must merge this in order to work https://github.com/decentrio/rollup-e2e-testing/pull/52
NOTE: Current setup only have one sequencer address, add check for inability to register new sequencer later
Summary by CodeRabbit
New Features
Bug Fixes
Chores
rollappEVMImage
to use the latest version in test setup.cosmossdk.io/math
in various test files.