Multiline text-object causes freeze/crash

mbmleone commented 2 years ago

Today we found a serious issue with Dymo Connect templates. They can cause a freeze with eventually a crash.

This happens in the following situation:

Dymo Connect 10.3.2.18
Template with multiline text object - like for example template in example.zip
Using the framework you call label.getObjectText(name) with name gotten from label.getObjectNames()
Issue doesn't happen when text object is limited to single line.

What happens is this:

Then after a long time it resumes and shows this error in console:

Uncaught InternalError: allocation size overflow
_getAddressObjectText

Can this please be investigated and fixed? Thanks!

giuliodamato commented 2 years ago

Hi @mbmleone, I found the bug and fixed it 😂

The freeze is originated by a nested for loop that tragically overwrites the control variable of its parent 🤦‍♂️

Changing the loop to this solves the problem:

for (gz = 0; gz < n.length; gz++)
{
  var i = dymo.xml.getElement(n[gz], "Text");
  o += dymo.xml.getElementText(i)
}

I'll release the fix in my repo tomorrow 😉

@dymosoftware: I really deserve some gadgets now 😂

giuliodamato commented 2 years ago

The fixed version is in my repo, please check it out and confirm us that it actually works. https://github.com/giuliodamato/dymo-connect-framework

The version in the repo also fixes issue #13.

mbmleone commented 2 years ago

Thanks for the fixed release. We just checked it and it indeed fixes the issue! Thanks again!

mbmleone commented 6 months ago

We just discovered this causes line breaks to disappear. Please make sure the line breaks are added inside the loop.

dymosoftware / dymo-connect-framework