dymosoftware / dymo-connect-framework

DYMO Connect Framework for Javascript.
Other
91 stars 53 forks source link

Project re-write to use node instead of just compiled js #52

Open zach2825 opened 2 years ago

zach2825 commented 2 years ago

Converting plain js into a modern node syntax that uses promises for all API calls.

I've done that so that everything is predictable and we can add timeouts to API calls and have better control over the code.

If anybody is interested let me know. If I am able to move forward with my project I'd be happy to invite people to it

I've already broken out the 41,000 line js into separate code and using node packages when possible. I was able to remove all the XHR and goog stuff which simplifies a ton. I've also tried fixing as many spelling mistakes as possible.

image

blester-mvc commented 2 years ago

🙋‍♂️ Interested!

zach2825 commented 2 years ago

I've only copied most of the functions into my project, removed the goog code, and used a package, I'm using Axios for API communication and I have getSettings and setSettings functions. I've done basic testing but I spent the day converting the framework.

I need help:

I ask that the working branch is develop but please feel free to make it yours an contribute if possible https://github.com/1to1plus/dymo-js-sdk

timint commented 2 years ago

removed the google code

Wohoo!! I mentioned the google code in issue #49 .

Did you make a pull request? It might be better to fork things as @dymosoftware just seems to wanna turn the page and not listen to feedback.

This library needs proper project management!

zach2825 commented 2 years ago

I did fork the repo and do a bunch of things over there. I did my best to update everything to factor out the google libs and make all actions execute using promises @timint

timint commented 2 years ago

@zach2825 Well done. It's the right thing to do. This library is a hundred times bigger than it needs to be. I have tried reaching management on Dymo.

zach2825 commented 2 years ago

Please feel free to check it out. It may not be perfect, please keep that in mind I didn't have much time to update it. We've been using the new code for like a year without problems. The link to the forked repo is above. I welcome any help. Good luck @timint

Roman991 commented 1 year ago

@dymosoftware 554KB of lib for some local http call, isnt it mad? Is there any hope for a refresh?

LOL zebra vs dymo size comparison (more or less the same lib philosophy) image

timint commented 1 year ago

@Roman991 This is just the tip of the ice berg. Looking at the code it's obvious they don't know what they are doing. Looking at this repo it's obvious they don't know how to maintain a repo neither.

I tried to reach management to let them know how bad things are. But they actively rejected me. Management is probably just as bad.