search

dyn4mik3 / OrderBook

Matching Engine for Limit Order Book
Other
361 stars 116 forks source link

bintrees is deprecated, suggests sortedcontainers #10

Open grantjenks opened 6 years ago

grantjenks commented 6 years ago

Hi, I'm the author of sortedcontainers and noticed that you're using the bintrees module. If you look at the PyPI page for bintrees then you'll see that development has stopped and sortedcontainers is recommended instead.

I'd love to see sortedcontainers used in more places. If I created a pull request which replaced bintrees with sortedcontainers, would that be merged?

dyn4mik3 commented 6 years ago

Thanks for the comment. Would be happy to merge an update to sortedcontainers.

On Thu, May 31, 2018 at 2:40 PM Grant Jenks notifications@github.com wrote:

Hi, I'm the author of sortedcontainers and noticed that you're using the bintrees module. If you look at the PyPI page for bintrees https://pypi.org/project/bintrees/ then you'll see that development has stopped and sortedcontainers is recommended instead.

I'd love to see sortedcontainers used in more places. If I created a pull request which replaced bintrees with sortedcontainers, would that be merged?

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/dyn4mik3/OrderBook/issues/10, or mute the thread https://github.com/notifications/unsubscribe-auth/AAJ5OrLpxoQYk_yuM2VT8PA1Gvs8JZZZks5t4GM0gaJpZM4UVx64 .