search

dynamic / foxystripe

FoxyStripe is a SilverStripe ecommerce module that integrates with FoxyCart.
http://foxystripe.org
BSD 3-Clause "New" or "Revised" License
8 stars 11 forks source link

ProductPage Controller - Requirement updates #335

Closed jsirish closed 6 years ago

jsirish commented 6 years ago

https://github.com/dynamic/foxystripe/blob/master/src/Controller/ProductPageController.php#L20

Can you implement the new Requirements method?

korthjp17 commented 6 years ago

i'll take a look at it, but things like this we may have to leave as requirements in the controller if possible. It looks like these are a little more advanced than just requiring the files.

jsirish commented 6 years ago

I think it's fine in this case to keep em in the controller