search

dynamic / foxystripe

FoxyStripe is a SilverStripe ecommerce module that integrates with FoxyCart.
http://foxystripe.org
BSD 3-Clause "New" or "Revised" License
8 stars 11 forks source link

FoxyStripePurchaseForm - only include Weight if greater than 0 #372

Closed jsirish closed 5 years ago

jsirish commented 5 years ago

fixes #317

Ensure Code is unique via index and validator

Move weight to Main tab due to being required

codecov[bot] commented 5 years ago

Codecov Report

Merging #372 into master will increase coverage by <.01%. The diff coverage is 21.05%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #372      +/-   ##
============================================
+ Coverage     29.04%   29.05%   +<.01%     
- Complexity      437      439       +2     
============================================
  Files            28       28              
  Lines          1821     1824       +3     
============================================
+ Hits            529      530       +1     
- Misses         1292     1294       +2
Impacted Files Coverage Δ Complexity Δ
src/Form/FoxyStripePurchaseForm.php 0% <0%> (ø) 33 <0> (+1) :arrow_up:
src/Page/ProductPage.php 15.38% <30.76%> (+0.49%) 31 <3> (+1) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8cd82bd...ede632d. Read the comment docs.