dynamic / foxystripe

FoxyStripe is a SilverStripe ecommerce module that integrates with FoxyCart.
http://foxystripe.org
BSD 3-Clause "New" or "Revised" License
8 stars 11 forks source link

BUGFIX single sign on issues #373

Closed muskie9 closed 5 years ago

muskie9 commented 5 years ago

This is a refactor to utilize the hyper media api to push customer data to Foxy. Post checkout data will still be processed with the existing methodology as the response is a xml data feed.

codecov[bot] commented 5 years ago

Codecov Report

Merging #373 into master will increase coverage by 0.89%. The diff coverage is 26.48%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #373      +/-   ##
============================================
+ Coverage     28.64%   29.54%   +0.89%     
- Complexity      454      474      +20     
============================================
  Files            28       31       +3     
  Lines          1854     1872      +18     
============================================
+ Hits            531      553      +22     
+ Misses         1323     1319       -4
Impacted Files Coverage Δ Complexity Δ
src/Model/FoxyCart.php 25.67% <ø> (-24.33%) 24 <0> (ø)
src/Admin/FoxyStripeAdmin.php 0% <ø> (ø) 15 <0> (ø) :arrow_down:
src/Controller/FoxyStripeController.php 0% <0%> (ø) 15 <8> (-27) :arrow_down:
src/Foxy/Transaction.php 0% <0%> (ø) 9 <9> (?)
src/Model/FoxyStripeSetting.php 82.7% <100%> (+0.42%) 33 <1> (+1) :arrow_up:
src/Model/FoxyStripeClient.php 60.16% <18.75%> (-2.9%) 44 <2> (+2)
src/Model/Order.php 43.26% <19.11%> (+3.26%) 31 <20> (+3) :arrow_up:
src/ORM/CustomerExtension.php 27.02% <22.85%> (-39.64%) 18 <13> (+13)
src/API/Client/CustomerClient.php 62.16% <62.16%> (ø) 14 <14> (?)
src/Security/PasswordEncryptor_BCrypt.php 72.72% <72.72%> (ø) 5 <5> (?)
... and 4 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update fa5fd48...3f288a1. Read the comment docs.

jsirish commented 5 years ago

fixes #323

muskie9 commented 5 years ago

I think this is in a good spot to test now.