search

dynamic / silverstripe-elemental-baseobject

A simple base DataObject to use with Elemental Content Blocks
BSD 3-Clause "New" or "Revised" License
1 stars 9 forks source link

BUG Can't install the newest 4.0.0-beta1 version via composer #34

Open Valandur opened 1 year ago

Valandur commented 1 year ago

Describe the bug Installing the newest 4.0.0-beta1 release (directly or as a requirement of dynamic/silverstripe-elemental-gallery @ 4.0.0-beta1) results in a composer error:

Your requirements could not be resolved to an installable set of packages.

because of:

dynamic/silverstripe-elemental-gallery[4.0.0-beta1, ..., 4.x-dev] require dynamic/silverstripe-elemental-baseobject ^4 -> satisfiable by dynamic/silverstripe-elemental-baseobject[4.0.0-alpha1, 4.0.0-beta1, 4.x-dev]
dynamic/silverstripe-elemental-baseobject[4.0.0-beta1, ..., 4.x-dev] require silvershop/silverstripe-hasonefield ^3 -> satisfiable by silvershop/silverstripe-hasonefield[3.0.0, ..., 3.1.0]
silvershop/silverstripe-hasonefield[3.0.0, ..., 3.1.0] require silverstripe/vendor-plugin ^1.0 -> found silverstripe/vendor-plugin[1.0.0, ..., 1.x-dev] but it conflicts with your root composer.json require (^2.0.0)

Most likely because silvershop/silverstripe-hasonefield @ v3 only supports silverstripe/vendor-plugin @ v1, but v2 is required by the silverstripe framework. This module should probably require "silvershop/silverstripe-hasonefield": "^4", since v4 of that module supports using silverstripe/vendor-plugin @ v2.

To Reproduce Steps to reproduce the behavior:

  1. Create a new SS5 repo
  2. Try to install this module (either directly or as a dependency of another module)

Expected behavior Module installs successfully

jsirish commented 1 year ago

hey thanks @Valandur for reporting the bug!

I've got #35 started to address this. It seems gorriecoe/silverstripe-linkfield will need to have its requirements updated as well for the PR to pass. I have a PR in over there as well, once that's merged this PR should pass and I can merge it in.

KallivdH commented 1 year ago

Link field has been updated in the meantime.

jsirish commented 1 year ago

Hey @KallivdH thanks for the reminder, I thought I had merged the PR.

Just published a new release 4.0.0-beta2, let me know if you have any additional issues.

lars-lemon8 commented 1 year ago

@jsirish , this one seems to work perfectly, thanks !