dynamic / silverstripe-elemental-blocks

Custom elements that work with SilverStripe Elemental module
BSD 3-Clause "New" or "Revised" License
8 stars 5 forks source link

refactor - migrate BaseElementObject to separate module #89

Closed jsirish closed 6 years ago

jsirish commented 6 years ago

ping #86

codecov[bot] commented 6 years ago

Codecov Report

Merging #89 into master will increase coverage by 1.4%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##             master      #89     +/-   ##
===========================================
+ Coverage     93.36%   94.76%   +1.4%     
+ Complexity       66       47     -19     
===========================================
  Files            15       14      -1     
  Lines           226      172     -54     
===========================================
- Hits            211      163     -48     
+ Misses           15        9      -6
Impacted Files Coverage Δ Complexity Δ
src/Model/GalleryImage.php 100% <ø> (ø) 4 <0> (ø) :arrow_down:
src/Model/FeatureObject.php 100% <ø> (ø) 4 <0> (ø) :arrow_down:
src/Model/PromoObject.php 95% <ø> (ø) 4 <0> (ø) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1b91f3c...ce50aaf. Read the comment docs.