dynamic / silverstripe-elemental-blog

Display a list of the most recent posts of a specific blog

BSD 3-Clause "New" or "Revised" License

1 stars 10 forks source link

Update for Elemental 4.0.0 #12

Closed obj63mc closed 5 years ago

obj63mc commented 5 years ago

Elemental is now at v4.0 so setting up to let that be installed

codecov[bot] commented 5 years ago

Codecov Report

Merging #12 into master will not change coverage. The diff coverage is n/a.

@@            Coverage Diff            @@
##             master      #12   +/-   ##
=========================================
  Coverage     86.84%   86.84%           
  Complexity       12       12           
=========================================
  Files             1        1           
  Lines            38       38           
=========================================
  Hits             33       33           
  Misses            5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update d8dbb92...7edaa63. Read the comment docs.

jsirish commented 5 years ago

Thanks @obj63mc for the PR! We'll work on getting this merged in by the end of the week.

Could you adjust to only require Elemental ^4.0@dev? We're going to roll these updates as a new major version.

obj63mc commented 5 years ago

You should be all set now

jsirish commented 5 years ago

Thanks for making that change.

It looks like some additional files snuck into the PR, could you zap the vendor folder from the PR?

https://github.com/dynamic/silverstripe-elemental-blog/pull/12/files/97932489aa9aa62b8645e59e7fe7d5fbcdd855e9..fb1c5f2dc79ccd2338188786b54aaa999064463b

I'll be online for a couple more hours and should be able to merge today once it's cleaned up. Thanks!

obj63mc commented 5 years ago

Yep, atom autocomplete added that, will push here in one sec.

obj63mc commented 5 years ago

You are all set

jsirish commented 5 years ago

merged. thanks again @obj63mc