search

dynamic / silverstripe-elemental-oembed

A block to embed media from other websites via oEmbed
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Remove implied recipe dependency #10

Closed chillu closed 5 years ago

chillu commented 5 years ago

First of all: Great work on building out the elemental block ecosystem 🎉

Technically the module isn't dependant on the whole recipe, it just inherits some dependencies from the elemental module.

Declaring dependence on the recipe is problematic, for example it forces you into installing silverstripe/errorpage even though it's not required for this module.

If you want to guard against e.g. elemental declaring a wider range of core dependencies than this module, you could specifically narrow down the range on silverstripe/framework, silverstripe/cms, etc

The vendor-plugin dependency is also implied through core.

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     68.75%   68.75%           
  Complexity        5        5           
=========================================
  Files             1        1           
  Lines            16       16           
=========================================
  Hits             11       11           
  Misses            5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c593ee...d8cec1f. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #10 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #10   +/-   ##
=========================================
  Coverage     68.75%   68.75%           
  Complexity        5        5           
=========================================
  Files             1        1           
  Lines            16       16           
=========================================
  Hits             11       11           
  Misses            5        5

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 5c593ee...d8cec1f. Read the comment docs.

muskie9 commented 5 years ago

Thanks for updating @chillu, always nice to do some cleanup making the package lighter!