dynamic / silverstripe-elemental-oembed

A block to embed media from other websites via oEmbed

BSD 3-Clause "New" or "Revised" License

0 stars 9 forks source link

Rename element type to "Media" #11

Closed chillu closed 5 years ago

chillu commented 5 years ago

OEmbed is more of an implementation detail, and not something users will be familiar with

muskie9 commented 5 years ago

Hey @chillu, love this! I think we need to adjust the ElementOembedTest:: testGetType() or drop that test all together. I checked Elemental and didn't see a test in there for the getType() method, so I think dropping that failed test method would be fine. Once that's fixed up we can get this merged in!

chillu commented 5 years ago

Sweet, changed the assertion. Thanks for writing unit tests!

codecov[bot] commented 5 years ago

Codecov Report

Merging #11 into master will increase coverage by 6.25%. The diff coverage is 100%.

@@            Coverage Diff            @@
##             master   #11      +/-   ##
=========================================
+ Coverage     68.75%   75%   +6.25%     
- Complexity        5     6       +1     
=========================================
  Files             1     1              
  Lines            16    20       +4     
=========================================
+ Hits             11    15       +4     
  Misses            5     5

Impacted Files	Coverage Δ	Complexity Δ
src/Elements/ElementOembed.php	`75% <100%> (+6.25%)`	`6 <1> (+1)`	:arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update cad0576...025198b. Read the comment docs.