search

dynamic / silverstripe-flexslider

SilverStripe FlexSlider
BSD 3-Clause "New" or "Revised" License
8 stars 17 forks source link

REFACTOR PHP 8 and PHPUnit 9 compatability #209

Closed jsirish closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #209 (22fbd42) into master (b5148f0) will decrease coverage by 2.87%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #209      +/-   ##
============================================
- Coverage     54.64%   51.76%   -2.88%     
+ Complexity       80       79       -1     
============================================
  Files             5        5              
  Lines           280      255      -25     
============================================
- Hits            153      132      -21     
+ Misses          127      123       -4
Flag Coverage Δ
unittests 51.76% <ø> (-2.88%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/ORM/FlexSlider.php 69.23% <0.00%> (-1.42%) :arrow_down:
src/Model/SlideImage.php 90.78% <0.00%> (-0.78%) :arrow_down:
src/Task/SlideLinkTask.php 0.00% <0.00%> (ø)
src/Task/DefaultSlideTypeTask.php 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b5148f0...22fbd42. Read the comment docs.

jsirish commented 2 years ago

i don't think we need either, was wondering why they were in there actually. I can zap