search

dynamic / silverstripe-foxy

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

BUGFIX replace refs of Options with Variations #103

Closed jsirish closed 4 years ago

jsirish commented 4 years ago

request caching

jsirish commented 4 years ago

saves 4 queries while checking isAvailable()

jsirish commented 4 years ago

I think I need to remove the getter/setter for isAvailable(), as I can't get tests to pass. Maybe I'll split that part out for now.

codecov[bot] commented 4 years ago

Codecov Report

Merging #103 into 1.2 will increase coverage by 0.34%. The diff coverage is 72.72%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.2     #103      +/-   ##
============================================
+ Coverage     48.98%   49.32%   +0.34%     
- Complexity      263      266       +3     
============================================
  Files            14       14              
  Lines          1037     1044       +7     
============================================
+ Hits            508      515       +7     
  Misses          529      529
Flag Coverage Δ Complexity Δ
#php 49.32% <72.72%> (+0.34%) 266.00 <3.00> (+3.00)
Impacted Files Coverage Δ Complexity Δ
src/Extension/PurchasableExtension.php 23.80% <0.00%> (ø) 8.00 <0.00> (ø)
src/Extension/Purchasable.php 90.83% <80.00%> (+0.51%) 25.00 <3.00> (+3.00)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 71a5881...522e10d. Read the comment docs.