search

dynamic / silverstripe-foxy

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

REFACTOR AddToCartForm - display Out Of Stock message in unavailable #114

Open jsirish opened 4 years ago

jsirish commented 4 years ago

related to https://github.com/dynamic/silverstripe-foxy-inventory/pull/27

jsirish commented 4 years ago

This PR may be unnecessary - just trying to avoid any additional getIsAvailable() calls on products

codecov[bot] commented 4 years ago

Codecov Report

Merging #114 into master will decrease coverage by 0.17%. The diff coverage is 57.14%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #114      +/-   ##
============================================
- Coverage     53.19%   53.02%   -0.18%     
+ Complexity      241      240       -1     
============================================
  Files            13       13              
  Lines           891      892       +1     
============================================
- Hits            474      473       -1     
- Misses          417      419       +2
Flag Coverage Δ Complexity Δ
#php 53.02% <57.14%> (-0.18%) 240.00 <0.00> (-1.00)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ Complexity Δ
src/Extension/PurchasableExtension.php 21.05% <50.00%> (-2.76%) 7.00 <0.00> (-1.00)
src/Form/AddToCartForm.php 62.85% <60.00%> (-1.38%) 40.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1789131...b255b2c. Read the comment docs.