search

dynamic / silverstripe-foxy

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

UPDATE variant adjustments #125

Closed muskie9 closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #125 (a8012ad) into master (300e346) will decrease coverage by 0.34%. The diff coverage is 3.03%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #125      +/-   ##
============================================
- Coverage     21.59%   21.25%   -0.35%     
- Complexity      255      266      +11     
============================================
  Files            13       13              
  Lines           926      941      +15     
============================================
  Hits            200      200              
- Misses          726      741      +15
Flag Coverage Δ
unittests 21.25% <3.03%> (-0.35%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Form/AddToCartForm.php 0.00% <0.00%> (ø)
src/Model/Variation.php 19.75% <0.00%> (-0.94%) :arrow_down:
src/Page/Product.php 24.46% <50.00%> (-0.18%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 300e346...a8012ad. Read the comment docs.

muskie9 commented 2 years ago

Test failures are due to PHP7.4 syntax. We will drop 7.3 support with this new major version and all remaining failures are phpcs related.