search

dynamic / silverstripe-foxy

BSD 3-Clause "New" or "Revised" License
1 stars 3 forks source link

Added code trimming for product and option codes #90

Closed mak001 closed 4 years ago

mak001 commented 4 years ago

Resolves #86 Resolves #77

codecov[bot] commented 4 years ago

Codecov Report

Merging #90 into 1.0 will increase coverage by 0.22%. The diff coverage is 43.33%.

Impacted file tree graph

@@             Coverage Diff              @@
##                1.0      #90      +/-   ##
============================================
+ Coverage     62.29%   62.51%   +0.22%     
- Complexity      194      204      +10     
============================================
  Files            11       11              
  Lines           724      763      +39     
============================================
+ Hits            451      477      +26     
- Misses          273      286      +13
Flag Coverage Δ Complexity Δ
#php 62.51% <43.33%> (+0.22%) 204.00 <6.00> (+10.00)
Impacted Files Coverage Δ Complexity Δ
src/Extension/Shippable.php 100.00% <ø> (ø) 2.00 <0.00> (ø)
src/Model/FoxyCategory.php 71.11% <ø> (ø) 15.00 <0.00> (ø)
src/Model/OptionType.php 82.35% <ø> (ø) 7.00 <0.00> (ø)
src/Model/ProductOption.php 62.11% <30.43%> (-4.33%) 40.00 <4.00> (+8.00) :arrow_down:
src/Extension/Purchasable.php 91.00% <83.33%> (+0.67%) 21.00 <2.00> (+1.00)
src/Model/Setting.php 86.84% <100.00%> (+1.12%) 25.00 <0.00> (ø)
src/Form/AddToCartForm.php 65.21% <0.00%> (+1.30%) 37.00% <0.00%> (+1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e312ae6...0b4109a. Read the comment docs.