search

dynamic / silverstripe-locator

SilverStripe Locator Module. Show locations on a map. Search by geoposition.
http://www.dynamicagency.com/labs/silverstripe-locator-module/
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

REFACTOR Location data import and export #210

Closed jsirish closed 5 years ago

jsirish commented 5 years ago

Import/Export should work both ways using default spreadsheet header row

Location

LocationCategory

muskie9 commented 5 years ago

Looks like there's a PHPCS failure as well.

codecov[bot] commented 5 years ago

Codecov Report

Merging #210 into master will decrease coverage by 6.4%. The diff coverage is 15.68%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #210      +/-   ##
============================================
- Coverage     69.25%   62.84%   -6.41%     
- Complexity       91      104      +13     
============================================
  Files             7        7              
  Lines           322      358      +36     
============================================
+ Hits            223      225       +2     
- Misses           99      133      +34
Flag Coverage Δ Complexity Δ
#php 62.84% <15.68%> (-6.41%) 104 <10> (+13)
Impacted Files Coverage Δ Complexity Δ
src/admin/LocationAdmin.php 0% <0%> (ø) 5 <0> (+1) :arrow_up:
src/bulkloader/LocationCsvBulkLoader.php 0% <0%> (ø) 9 <6> (+7) :arrow_up:
src/objects/LocationCategory.php 100% <100%> (ø) 7 <0> (ø) :arrow_down:
src/objects/Location.php 71.42% <17.64%> (-28.58%) 15 <4> (+5)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 4e9ab40...58773d9. Read the comment docs.