Closed muskie9 closed 4 years ago
Merging #223 into master will decrease coverage by
15.99%
. The diff coverage is12.62%
.
@@ Coverage Diff @@
## master #223 +/- ##
=============================================
- Coverage 61.89% 45.89% -16.00%
- Complexity 105 161 +56
=============================================
Files 7 12 +5
Lines 370 512 +142
=============================================
+ Hits 229 235 +6
- Misses 141 277 +136
Flag | Coverage Δ | Complexity Δ | |
---|---|---|---|
#php | 45.89% <12.62%> (-16.00%) |
161.00 <34.00> (+56.00) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Impacted Files | Coverage Δ | Complexity Δ | |
---|---|---|---|
src/Model/Location.php | 73.58% <ø> (ø) |
16.00 <0.00> (?) |
|
src/Page/LocationPage.php | 0.00% <0.00%> (ø) |
16.00 <16.00> (?) |
|
src/Tasks/EmailAddressTask.php | 0.00% <0.00%> (ø) |
6.00 <0.00> (?) |
|
src/Tasks/LocationCategoriesTask.php | 0.00% <ø> (ø) |
9.00 <0.00> (?) |
|
src/Tasks/LocationPublishTask.php | 0.00% <ø> (ø) |
14.00 <0.00> (?) |
|
src/Tasks/LocationToPageTask.php | 0.00% <0.00%> (ø) |
11.00 <11.00> (?) |
|
src/admin/LocationAdmin.php | 0.00% <0.00%> (ø) |
6.00 <0.00> (+1.00) |
|
src/bulkloader/LocationCsvBulkLoader.php | 0.00% <ø> (ø) |
9.00 <0.00> (ø) |
|
src/form/LocatorForm.php | 97.67% <ø> (+16.27%) |
11.00 <0.00> (ø) |
|
src/Page/Locator.php | 87.14% <87.50%> (ø) |
23.00 <5.00> (?) |
|
... and 9 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 4e09b0a...b6c65e1. Read the comment docs.
since this will be used in a new major release, are there any objections to implementing #187
@mak001 good idea, let's make sure we get that tackled before releasing the new major.
Update the overall model pattern to be Page based.