dynamic / silverstripe-locator

SilverStripe Locator Module. Show locations on a map. Search by geoposition.
http://www.dynamicagency.com/labs/silverstripe-locator-module/
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

CI Github Workflow #231

Closed jsirish closed 2 years ago

jsirish commented 2 years ago

@muskie9 any idea what's going on with the tests? Works on local running PHP8, SS 4.11 and PHPUNIT 9

codecov[bot] commented 2 years ago

Codecov Report

Base: 61.89% // Head: 45.90% // Decreases project coverage by -15.99% :warning:

Coverage data is based on head (7020a40) compared to base (81b291d). Patch coverage: 12.71% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #231 +/- ## ============================================= - Coverage 61.89% 45.90% -16.00% - Complexity 105 162 +57 ============================================= Files 7 13 +6 Lines 370 488 +118 ============================================= - Hits 229 224 -5 - Misses 141 264 +123 ``` | Flag | Coverage Δ | | |---|---|---| | php | `?` | | | unittests | `45.90% <12.71%> (?)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic) | Coverage Δ | | |---|---|---| | [src/Model/Location.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL01vZGVsL0xvY2F0aW9uLnBocA==) | `74.00% <ø> (ø)` | | | [src/Page/LocationPage.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL1BhZ2UvTG9jYXRpb25QYWdlLnBocA==) | `0.00% <0.00%> (ø)` | | | [src/Tasks/EmailAddressTask.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL1Rhc2tzL0VtYWlsQWRkcmVzc1Rhc2sucGhw) | `0.00% <0.00%> (ø)` | | | [src/Tasks/LocationCategoriesTask.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL1Rhc2tzL0xvY2F0aW9uQ2F0ZWdvcmllc1Rhc2sucGhw) | `0.00% <ø> (ø)` | | | [src/Tasks/LocationPublishTask.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL1Rhc2tzL0xvY2F0aW9uUHVibGlzaFRhc2sucGhw) | `0.00% <ø> (ø)` | | | [src/Tasks/LocationToPageTask.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL1Rhc2tzL0xvY2F0aW9uVG9QYWdlVGFzay5waHA=) | `0.00% <0.00%> (ø)` | | | [src/admin/LocationAdmin.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL2FkbWluL0xvY2F0aW9uQWRtaW4ucGhw) | `0.00% <0.00%> (ø)` | | | [src/admin/LocationsAdmin.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL2FkbWluL0xvY2F0aW9uc0FkbWluLnBocA==) | `0.00% <0.00%> (ø)` | | | [src/bulkloader/LocationCsvBulkLoader.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL2J1bGtsb2FkZXIvTG9jYXRpb25Dc3ZCdWxrTG9hZGVyLnBocA==) | `0.00% <ø> (ø)` | | | [src/form/LocatorForm.php](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#diff-c3JjL2Zvcm0vTG9jYXRvckZvcm0ucGhw) | `97.67% <ø> (+16.27%)` | :arrow_up: | | ... and [12 more](https://codecov.io/gh/dynamic/silverstripe-locator/pull/231/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

muskie9 commented 2 years ago

@jsirish I was able to track it down. It was aspects of the composer file that snuck in with the work that converted locations to pages: https://github.com/dynamic/silverstripe-locator/pull/231/commits/14ead804ee96e16f301b934d791e107332bcbdbf