dynamic / silverstripe-locator

SilverStripe Locator Module. Show locations on a map. Search by geoposition.
http://www.dynamicagency.com/labs/silverstripe-locator-module/
BSD 3-Clause "New" or "Revised" License
21 stars 7 forks source link

Upgrade v3 to current geocoder compatibility #243

Open nathanbrauer opened 6 months ago

nathanbrauer commented 6 months ago

Just noticed you're working on this at the same time I am - starting a pull request.

FYI - due to several other packages requiring dynamic/silverstripe-geocoder:^1.0, you may need to run the following until it's safe to upgrade all the others (e.g. core-tools, silverstripe-elemental-customer-service, etc):

ddev composer require dynamic/silverstripe-geocoder:"2.0.4 as 1.3.1"
codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 74.31%. Comparing base (a5d1c00) to head (a8114b2).

Files Patch % Lines
src/pages/LocatorController.php 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## 3 #243 +/- ## ========================================= Coverage 74.31% 74.31% Complexity 107 107 ========================================= Files 7 7 Lines 366 366 ========================================= Hits 272 272 Misses 94 94 ``` | [Flag](https://app.codecov.io/gh/dynamic/silverstripe-locator/pull/243/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/dynamic/silverstripe-locator/pull/243/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic) | `74.31% <0.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=dynamic#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.