Minor refinements to PR #4

dynamic / silverstripe-maintenance-mode

Maintainance/Offline Mode Module for SilverStripe

BSD 2-Clause "Simplified" License

21 stars 18 forks source link

Minor refinements to PR #4 #5

Closed patricknelson closed 9 years ago

patricknelson commented 9 years ago

See PR #4 -- just passing in second parameter. Just making a new DataModel instance since I think that's all it really needs here.

patricknelson commented 9 years ago

So I take it this worked for you in 3.2.x as well, right?

dljoseph commented 9 years ago

Hi @patricknelson - definitely works in both. Many thanks for your contribution, which has been merged and now available on packagist.

patricknelson commented 9 years ago

Ok awesome! I just finished testing in 3.1 too. While on one hand you'd think it's simple enough for it to work, you still gotta test it to be sure (especially in SilverStripe). You're welcome and thanks for being quick to respond; I've already got this deployed to production, so it makes future updates much easier for me (not having to monkey patch everything after doing a full composer update).