Closed holdenmai closed 2 years ago
I have added scenarios within the differing unit tests to cover each of the cases mentioned. Is it preferred that they become standalone cases to better show what negative case they are trying to cover?
Thank you @holdenmai
Is it preferred that they become standalone cases to better show what negative case they are trying to cover?
Yes, maybe having separate tests would be better... or try to simplify/explain better the existing ones.
I have reorganized the unit tests to better show the different scenarios being covered.
LGTM!
@metoule ?
There is just 3 conversations still open that I'm not sure if they are now resolved ...
Sorry for the late review! The code looks good to me, the test cases as well, I still have a few questions, but nothing major.
Implementation of collection initializer syntax support for constructor #194 Managed to somehow close the original PR on accident during rebase operation pull 246, but all comments have now been resolved.
You can now write
as well as implementations supporting multiple parameters in the Add method such as
new MyClassAdder(){{ 1, 2, 3, 4, 5},{\"6\" },7 }
andnew Dictionary<int, string>(){{1, \"1\"}, {2, \"2\"}, {3, \"3\"}, {4, \"4\"}, {5, \"5\"}}
Reference to method parameters is also supported like below
target.Eval<System.Collections.Generic.List<string>>("new List<string>(){StrProp = string.Empty}", new Parameter("StrProp", "0")) target.Eval<System.Collections.Generic.List<string>>("new List<string>(){StrValue()}", new Parameter("StrValue", new Func<string>(() => "Func")))