search

dynamicexpresso / DynamicExpresso

C# expressions interpreter
http://dynamic-expresso.azurewebsites.net/
MIT License
2.02k stars 379 forks source link

Broken localization #328

Closed cpiber closed 1 week ago

cpiber commented 1 week ago

318 broke localization

Some strings are still localized (e.g. ErrorMessages.Format is still used), but many actually useful messages are hardcoded again, like "Unknown identifier" https://github.com/dynamicexpresso/DynamicExpresso/blob/590910db84145fcbc268258cc20739e931882c44/src/DynamicExpresso.Core/Exceptions/UnknownIdentifierException.cs#L10

davideicardi commented 1 week ago

Thank you for the issue. You are right. We will try to resolve this issue in the future. As usual, any help is appreciated ;-) .

metoule commented 1 week ago

Ooops sorry about that, I'll work on it 🙈

cpiber commented 1 week ago

@metoule My PR that fixes it is already merged, I forgot to close this