dynamics-of-stellar-systems / dynamite

dynamics, age and metallicity indicators tracing evolution
MIT License
10 stars 1 forks source link

Dyna install issue #345

Closed sthater closed 7 months ago

sthater commented 7 months ago

A copy of a mail by Nilanjana:

I am facing an issue while installing the DYNAMITE software which I can't solve using the GitHub issue page. For the installation, I have followed this link. The issue arises while compiling the fortran programs. At the "make all" step, I get the following error : collect2: error: ld returned 1 exit status make: *** [Makefile:278: triaxnnls_CRcut] Error 1 [For your reference, my output matches the screenshots shown in this issue page - link.]

As mentioned in this link, I have tried changing the command from flags += -funroll-loops -ftree-loop-linear to flags += -funroll-loops # -ftree-loop-linear but got the same error. After doing 'make all', I am not get all the executables as mentioned in the installation guide which is possibly due to some error while installing GALAHAD (link). As suggested here, I have tried to install GALAHAD separately which comes with its own issues during the installation. I also have tried the executables available at this link.

maindlt commented 7 months ago

Hi @NilanjanaNandi,

yes, it seems something went wrong in installing GALAHAD. Does installing the Fortran executables without GALAHAD work? The command for this is make distclean; make nogal. This will result in DYNAMITE only working with the Python NNLS (and not LegacyWeightSolver) with minimal impact. Note about working with the tutorials: the weight_solver_settings in the tutorials' config files would need to be changed from

weight_solver_settings:
    type: "LegacyWeightSolver"
    nnls_solver: 1

to

weight_solver_settings:
    type: "NNLS"
    nnls_solver: 'scipy'

Best regards, Thomas

NilanjanaNandi commented 7 months ago

I could possibly install DYNAMITE. This is the output of test-nnls.py. kinchi2_vs_model_id

The chi^2 is much higher compared to the plot shown in the installation guide but the code is running fine. kinematic_map_kinset1 Also, h_3 and h_4 moments are blank in the kinematic map. I wonder if these are arising (chi^2 plot : what I obtained vs the result shown here and the absence of h_3 and h_4) as a result of using a different type of the weight solver.

What is the difference between the (1) DYNAMITE with the GALAHAD (the LegacyWeightSolver) and the SciPy-based NNLS weight solvers (installation option A) and (2) DYNAMITE with just the SciPy-based NNLS weight solver (installation option B). Does it make huge difference in the output results?

Many thanks for solving my issue. Regards, Nilanjana

maindlt commented 7 months ago

Hi Nilanjana,

your results from test_nnls.py look as expected and I think your installation is ok:

Please let us know whether this works for you.

All the best, Thomas

NilanjanaNandi commented 7 months ago

Perfect! Many many thanks for your help.

maindlt commented 7 months ago

Wonderful, have a great day!