How to add GH coefficient errors if number_GH (config file) > number_GH (kinematics data)?

dynamics-of-stellar-systems / dynamite

dynamics, age and metallicity indicators tracing evolution

MIT License

10 stars 1 forks source link

How to add GH coefficient errors if number_GH (config file) > number_GH (kinematics data)? #353

Closed maindlt closed 4 months ago

maindlt commented 7 months ago

How to treat number_GH (config file) > number_GH (kinematics data) in kinematics.GaussHermite.get_data(...)?

The meanwhile merged PR #325 implements that in that case, both the added GH coefficients and their errors (before any systematic errors are applied) will be zero (hx=dhx=0).

Is this behavior ok or shall the dhx get some nonzero value as suggested by data_prep/generate_kin_input.py (dhx=0, dhx=0.005, dhx=0.3,...)?

maindlt commented 6 months ago

Per discussion with Prash & Alice: Demand sys_err > 0 then, but wait with implementation until dh1, dh2 vs dv, sigma issue #358 is solved.