search

dynamics-of-stellar-systems / dynamite

dynamics, age and metallicity indicators tracing evolution
MIT License
10 stars 1 forks source link

Numerical stability: q=1.0 in MGE needs to be changed to 0.9999, not 0.99999 #369

Closed maindlt closed 2 months ago

maindlt commented 4 months ago

In a production run, the following warnings were encountered, which leads to all chi2=nan:

[INFO] 06:38:29 - dynamite.config_reader.Configuration - Config file ./NGC4900_analysis/Dynamite/IN/NGC4900_config0.yaml read.
[INFO] 06:38:29 - dynamite.config_reader.Configuration - io_settings...
[INFO] 06:38:29 - dynamite.config_reader.Configuration - Output directory tree: NGC4900_analysis/Dynamite/OUT/.
[INFO] 06:38:29 - dynamite.config_reader.Configuration - system_attributes...
[INFO] 06:38:29 - dynamite.config_reader.Configuration - model_components...
[WARNING] 06:38:29 - dynamite.mges.MGE - changing q=1.0 to q=0.99999 for numerical stability.
[WARNING] 06:38:29 - dynamite.mges.MGE - changing q=1.0 to q=0.99999 for numerical stability.
[WARNING] 06:38:29 - dynamite.mges.MGE - changing q=1.0 to q=0.99999 for numerical stability.

leading to...

[INFO] 06:38:30 - dynamite.orblib.LegacyOrbitLibrary - Calculating initial conditions
[WARNING] 06:38:30 - dynamite.orblib.LegacyOrbitLibrary - ...failed! cmd_orb_start exit code 0. Message: Note: The following floating-point exceptions are signalling: IEEE_UNDERFLOW_FLAG
STOP Failed test 5

As the model run works for q=0.9999, fix the problem by changing 0.99999 to 0.9999.

maindlt commented 2 months ago

Fixed by commit a11cd7f03fafef2be7618d4994c7012412c148f3 into master branch.