Bin and apertures check

dynamics-of-stellar-systems / dynamite

dynamics, age and metallicity indicators tracing evolution

MIT License

14 stars 1 forks source link

Bin and apertures check #372

Closed maindlt closed 3 months ago

maindlt commented 6 months ago

Upon reading the aperture, bins, and kinematics files, DYNAMITE now checks for

consistent number of velocity (kinematics) bins between the kinematics and bins input files
consistent number of spatial bins between the aperture and bins input files

Tested with test_nnls.py (with provoking errors in all three input files) and "all passed" with test_notebooks.sh.

@sthater: perhaps you and/or Julia can test this with your erroneous data and verify that you get meaningful error messages.

Closes #370.

juliala2504 commented 4 months ago

Tested with a bin.dat that was created with a bintable written in IDL, which starts at 1 instead of 0. Therefore no consistent number of velocity (kinematics) bins between the kinematics and bins input files.

Old error, that only occured at the end of a model during plotting:

ValueError: All (kin)chi2 values are nan.

Now, It successfully raised the following error:

ValueError: Numbers of kinematic bins do not match: 149 (length of gauss_hermite_kins_nifs_gh12.ecsv), 149 (last id in gauss_hermite_kins_nifs_gh12.ecsv), max number 150 in bins_nifs_idl.dat.

maindlt commented 3 months ago

Hello @juliala2504,

many thanks for testing (and sorry for my late reply)! I again successfully ran test_notebooks.sh with both Python 3.12 and 3.10 and will merge into master and delete this branch...

Cheers, Thomas