Legacy nnls file cleanup

dynamics-of-stellar-systems / dynamite

dynamics, age and metallicity indicators tracing evolution

MIT License

10 stars 1 forks source link

Legacy nnls file cleanup #378

Closed maindlt closed 2 months ago

maindlt commented 2 months ago

Based on today's discussion, this PR implements:

LegacyWeightSolver.solve() deletes the nn.orbmat.out file after a successful solve.
Add LegacyWeightSolver deprecation info to the log file and the changelog in the docs.

Idea for testing: run any set of models with weight solver type: "LegacyWeightSolver" and verify that the file nn.orbmat.out is not in the model directory.

Closes #377

prashjet commented 2 months ago

Ran test_notebooks.sh and all passed successfully. Happy to merge.

Thanks Thomas! :)