search

dynamicslab / hydrogym

An RL-Gym for Challenge Problems in Data-Driven Modeling and Control of Fluid Dynamics.
https://hydrogym.readthedocs.io
MIT License
48 stars 10 forks source link

firedrake_adjoint no longer supported #103

Open SamAhnert opened 10 months ago

SamAhnert commented 10 months ago

The use of the "firedrake_adjoint" module is deprecated in favor of firedrake.adjoint causing breaking changes for our environments ala:

https://github.com/firedrakeproject/firedrake/commit/ddc60a1dba68bd7cb7eb53e3e8586ef556983f7c

Will be fixed in sa/bug-fix-Oct23 branch.

SamAhnert commented 10 months ago

This seems to be a greater problem to do with the differentiability of the environment. Will not prioritize this at the moment, but it seems like the with this new change, differentiability is not supported

ludgerpaehler commented 10 months ago

I am talking with Nacime Bouziani at the moment, so we should hopefully get that fixed soon :)

ludgerpaehler commented 10 months ago

(One of the Firedrake people who wrote the PyTorch integration)